Comments on: SHOW PROFILES in MySQL 5.1 http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/ Wizardry and community Wed, 25 Nov 2009 00:32:10 +0000 http://wordpress.org/?v=2.6.1 By: Jeremy Cole http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-7 Jeremy Cole Thu, 15 Nov 2007 19:42:41 +0000 http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-7 Hi Giuseppe, No offense was taken. Actually, I just looked at the code you provided as 5.1.23. There are basically no changes from 5.0... The only diffs are because of changes in 5.1, and a new macro COMMUNITY_SERVER. What do you mean 80% of the code has changed? The thd->proc_info to thd_proc_info() macro change is obvious, and yes this accounts for actually closer to 99% of the patch size by line, but it is for the most part a trivial search and replace. The macro should have been implemented in 5.1 a long long time ago actually. I would not say that the implementation has "evolved" at all... Regards, Jeremy Hi Giuseppe,

No offense was taken. Actually, I just looked at the code you provided as 5.1.23. There are basically no changes from 5.0… The only diffs are because of changes in 5.1, and a new macro COMMUNITY_SERVER. What do you mean 80% of the code has changed?

The thd->proc_info to thd_proc_info() macro change is obvious, and yes this accounts for actually closer to 99% of the patch size by line, but it is for the most part a trivial search and replace. The macro should have been implemented in 5.1 a long long time ago actually.

I would not say that the implementation has “evolved” at all…

Regards,

Jeremy

]]> By: gmax http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-5 gmax Thu, 15 Nov 2007 09:05:26 +0000 http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-5 Hi Jeremy, No disrespect intended for your coding skills. I was just pointing out that SHOW PROFILES implementation has evolved. The feature is quite complex and it has impact on mostly everything. It was almost inevitable that, as the code base changed since its original proposal, the patch needed adjustments. That said, I hope you will help out with the testing, perhaps by making some more binaries available from dorsalsource.org. Cheers Giuseppe Hi Jeremy,
No disrespect intended for your coding skills.
I was just pointing out that SHOW PROFILES implementation has evolved.
The feature is quite complex and it has impact on mostly everything. It was almost inevitable that, as the code base changed since its original proposal, the patch needed adjustments.

That said, I hope you will help out with the testing, perhaps by making some more binaries available from dorsalsource.org.

Cheers

Giuseppe

]]> By: gmax http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-4 gmax Thu, 15 Nov 2007 07:32:05 +0000 http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-4 Kevin, yes, ported means that it will make it to the official binaries and into bitkeeper. But note that I said. "if approved". Currently, the code is under review. Giuseppe Kevin,
yes, ported means that it will make it to the official binaries and into bitkeeper. But note that I said. “if approved”.
Currently, the code is under review.
Giuseppe

]]> By: Kevin Burton http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-3 Kevin Burton Thu, 15 Nov 2007 06:07:38 +0000 http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-3 Ported meaning it's going to make it into official binaries and into bitkeeper? Kevin Ported meaning it’s going to make it into official binaries and into bitkeeper?

Kevin

]]> By: Jeremy Cole http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-2 Jeremy Cole Thu, 15 Nov 2007 00:48:06 +0000 http://blogs.mysql.com/gmax/2007/11/14/show-profiles-in-mysql-51/#comment-2 Hi Giuseppe, To be fair, not much of my original code was left in what went into 5.0, either. Chad reworked the patch, as the original one I provided was more of a proof of concept, and MySQL couldn't get their act together enough for me to finish it up myself. I only originally asked for the macro patch to be subsumed so that I could work on the real features without going insane. Instead, MySQL took the entire patchset in its half baked state and Chad fixed it up. Regards, Jeremy Hi Giuseppe,

To be fair, not much of my original code was left in what went into 5.0, either. Chad reworked the patch, as the original one I provided was more of a proof of concept, and MySQL couldn’t get their act together enough for me to finish it up myself. I only originally asked for the macro patch to be subsumed so that I could work on the real features without going insane. Instead, MySQL took the entire patchset in its half baked state and Chad fixed it up.

Regards,

Jeremy

]]>